Skip to content

stubs/requests: expand types for files #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 6 commits into from
Jun 1, 2022
Merged

stubs/requests: expand types for files #7999

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9fe880
stubs/requests: expand types for files
tommilligan May 31, 2022
f601904
[fixup] fix build failures
tommilligan May 31, 2022
6216bbd
[review] files don't have to have uniform structure
tommilligan May 31, 2022
a588978
[review] add missing TypeAlias
tommilligan May 31, 2022
b6ec360
[review] feedback from Akuli
tommilligan May 31, 2022
ca99caf
[review] do not require mutability for file headers
tommilligan Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions stubs/requests/requests/sessions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,16 @@ class SessionRedirectMixin:
_Data: TypeAlias = str | bytes | Mapping[str, Any] | Iterable[tuple[str, str | None]] | IO[Any]
_Auth: TypeAlias = Union[tuple[str, str], _auth.AuthBase, Callable[[PreparedRequest], PreparedRequest]]
_Cert: TypeAlias = Union[str, tuple[str, str]]
_Files: TypeAlias = (
Mapping[str, SupportsRead[str | bytes] | str | bytes]
| Mapping[str, tuple[str | None, SupportsRead[str | bytes] | str | bytes]]
| Mapping[str, tuple[str | None, SupportsRead[str | bytes] | str | bytes, str]]
| Mapping[str, tuple[str | None, SupportsRead[str | bytes] | str | bytes, str, _TextMapping]]
)
# Files is passed to requests.utils.to_key_val_list()
_FileName: TypeAlias = str | None
_FileContent: TypeAlias = SupportsRead[str | bytes] | str | bytes
_FileContentType: TypeAlias = str
_FileCustomHeaders: TypeAlias = Mapping[str, str]
_FileSpecTuple2: TypeAlias = tuple[_FileName, _FileContent]
_FileSpecTuple3: TypeAlias = tuple[_FileName, _FileContent, _FileContentType]
_FileSpecTuple4: TypeAlias = tuple[_FileName, _FileContent, _FileContentType, _FileCustomHeaders]
_FileSpec: TypeAlias = _FileContent | _FileSpecTuple2 | _FileSpecTuple3 | _FileSpecTuple4
_Files: TypeAlias = Mapping[str, _FileSpec] | Iterable[tuple[str, _FileSpec]]
_Hook: TypeAlias = Callable[[Response], Any]
_HooksInput: TypeAlias = Mapping[str, Iterable[_Hook] | _Hook]

Expand Down