Skip to content

Define __slots__ for object as Iterable[str] / Iterable[Union[str, unicode]] #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Dec 19, 2016
Merged

Define __slots__ for object as Iterable[str] / Iterable[Union[str, unicode]] #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9afb5e
Define __slots__ for object as Iterable[str] / Iterable[Union[str, un…
TrueBrain Dec 18, 2016
bce33ed
A string as __slots__ value is also valid and represents a single item
TrueBrain Dec 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/2/__builtin__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class classmethod: pass # Special, only valid as a decorator.
class object:
__doc__ = ... # type: Optional[str]
__class__ = ... # type: type
__slots__ = ... # type: Optional[Union[str, unicode, Iterable[Union[str, unicode]]]]

@ambv ambv Dec 19, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since you're already doing a Union, it would be better to say:
Union[None, str, unicode, Iterable[str], Iterable[unicode]]

Much shorter :) Well, at least much flatter :)


def __init__(self) -> None: ...
def __new__(cls) -> Any: ...
Expand Down
1 change: 0 additions & 1 deletion stdlib/3.4/asyncio/events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ AF_UNSPEC = 0 # from socket
AI_PASSIVE = 0

class Handle:
__slots__ = ... # type: List[str]
_cancelled = False
_args = ... # type: List[Any]
def __init__(self, callback: Callable[..., Any], args: List[Any],
Expand Down
1 change: 0 additions & 1 deletion stdlib/3.4/asyncio/futures.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ from concurrent.futures import (
class InvalidStateError(Error): ...

class _TracebackLogger:
__slots__ = ... # type: List[str]
exc = ... # type: BaseException
tb = ... # type: List[str]
def __init__(self, exc: Any, loop: AbstractEventLoop) -> None: ...
Expand Down
1 change: 1 addition & 0 deletions stdlib/3/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class object:
__doc__ = ... # type: Optional[str]
__class__ = ... # type: type
__dict__ = ... # type: Dict[str, Any]
__slots__ = ... # type: Optional[Union[str, Iterable[str]]]

def __init__(self) -> None: ...
def __new__(cls) -> Any: ...
Expand Down