Skip to content

Add typing._SubscriptableSpecialForm and use it to fix various special forms #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KotlinIsland wants to merge 1 commit into from
Closed

Add typing._SubscriptableSpecialForm and use it to fix various special forms #7509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions stdlib/typing.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,14 @@ _promote = object()
# N.B. Keep this definition in sync with typing_extensions._SpecialForm
@_final
class _SpecialForm:
def __getitem__(self, parameters: Any) -> object: ...
if sys.version_info >= (3, 10):
def __or__(self, other: Any) -> _SpecialForm: ...
def __ror__(self, other: Any) -> _SpecialForm: ...


class _SubscriptableSpecialForm(_SpecialForm): # type: ignore
def __getitem__(self, parameters: Any) -> object: ...

_F = TypeVar("_F", bound=Callable[..., Any])
_P = _ParamSpec("_P")
_T = TypeVar("_T")
Expand All @@ -503,26 +506,26 @@ def overload(func: _F) -> _F: ...
# Otherwise, flake8 erroneously flags them as undefined.
# `_SpecialForm` objects in typing.py that are not used elswhere in the same file
# do not need the default value assignment.
Union: _SpecialForm = ...
Generic: _SpecialForm = ...
Union: _SubscriptableSpecialForm = ...
Generic: _SubscriptableSpecialForm = ...
# Protocol is only present in 3.8 and later, but mypy needs it unconditionally
Protocol: _SpecialForm = ...
Callable: _SpecialForm = ...
Type: _SpecialForm = ...
Protocol: _SubscriptableSpecialForm = ...
Callable: _SubscriptableSpecialForm = ...
Type: _SubscriptableSpecialForm = ...
NoReturn: _SpecialForm = ...

Optional: _SpecialForm
Tuple: _SpecialForm
ClassVar: _SpecialForm
Optional: _SubscriptableSpecialForm
Tuple: _SubscriptableSpecialForm
ClassVar: _SubscriptableSpecialForm
if sys.version_info >= (3, 8):
Final: _SpecialForm
Final: _SubscriptableSpecialForm
def final(f: _T) -> _T: ...
Literal: _SpecialForm
Literal: _SubscriptableSpecialForm
# TypedDict is a (non-subscriptable) special form.
TypedDict: object

if sys.version_info >= (3, 11):
Self: _SpecialForm
Self: _SubscriptableSpecialForm
Never: _SpecialForm = ...

if sys.version_info < (3, 7):
Expand Down