Skip to content

Backport more Self-related changes to Python 2 - #7166

Merged
JelleZijlstra merged 3 commits into
python:masterfrom
AlexWaygood:imethods
Feb 8, 2022
Merged

JelleZijlstra merged 3 commits into
python:masterfrom
AlexWaygood:imethods

Conversation

@AlexWaygood

Copy link
Copy Markdown
Member

@github-actions

This comment has been minimized.

@AlexWaygood
AlexWaygood marked this pull request as draft February 8, 2022 17:35
@github-actions

This comment has been minimized.

@AlexWaygood
AlexWaygood marked this pull request as ready for review February 8, 2022 17:40
@github-actions

github-actions Bot commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra
JelleZijlstra merged commit 5f830d0 into python:master Feb 8, 2022
@AlexWaygood
AlexWaygood deleted the imethods branch February 8, 2022 17:53
@JelleZijlstra

Copy link
Copy Markdown
Member

What did happen to check_consistent here? Seems like it succeeded: https://github.com/python/typeshed/runs/5113546204?check_suite_focus=true

@AlexWaygood

Copy link
Copy Markdown
Member Author

What did happen to check_consistent here? Seems like it succeeded: https://github.com/python/typeshed/runs/5113546204?check_suite_focus=true

Yeah, I have no idea why it succeeded and then promptly failed on the next PR. It's bizarre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants