Skip to content

Do not run actions on forks - #7074

Closed
sobolevn wants to merge 1 commit into
python:masterfrom
sobolevn:patch-124
Closed

sobolevn wants to merge 1 commit into
python:masterfrom
sobolevn:patch-124

Conversation

@sobolevn

Copy link
Copy Markdown
Member

Closes #7066

@Akuli

Akuli commented Feb 5, 2022

Copy link
Copy Markdown
Collaborator

As discussed in the issue, there turned out to be one person who strongly dislikes this. If you equally strongly like this, you can disable the actions in your fork's settings. But thanks for bringing this up :)

@Akuli Akuli closed this Feb 5, 2022
@nightlark

nightlark commented May 30, 2022 •

Copy link
Copy Markdown

@Akuli most of the reasons for the strong dislikes aren't relevant, since the workflow_dispatch trigger in the workflow file enables easily running the tests in forks in any branch as needed.

I noticed that some of the other workflows (such as the daily scheduled tests) don't have workflow_dispatch listed as a trigger; might be good to get those added in.

@hugovk

hugovk commented May 30, 2022

Copy link
Copy Markdown
Member

@Akuli most of the reasons for the strong dislikes aren't relevant, since the workflow_dispatch trigger in the workflow file enables easily running the tests in forks in any branch as needed.

It's still relevant.

Sure, it's possible to trigger via workflow_dispatch, but it's still an extra impediment. Making the human do more work so the computer can do less.

As shown in this example screencast, it can take 9 clicks and 25 seconds to trigger each and every build with workflow_dispatch: python/bedevere#461 (comment)

I noticed that some of the other workflows (such as the daily scheduled tests) don't have workflow_dispatch listed as a trigger; might be good to get those added in.

Good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we need to run actions on forks?

4 participants