Skip to content

Use ParamSpec in unittest.case - #7012

Merged
srittau merged 6 commits into
python:masterfrom
sobolevn:patch-111
Jan 25, 2022
Merged

srittau merged 6 commits into
python:masterfrom
sobolevn:patch-111

Conversation

@sobolevn

Copy link
Copy Markdown
Member

No description provided.

@sobolevn

Copy link
Copy Markdown
Member Author

That's all I can find in stdlib 🎉

@JelleZijlstra

Copy link
Copy Markdown
Member

I think these can also return object, like with the asyncio one.

@sobolevn

Copy link
Copy Markdown
Member Author

Oh, I've also missed cases like assertRaises / etc

@github-actions

This comment has been minimized.

@sobolevn

Copy link
Copy Markdown
Member Author

I will double check that I've covered everything tomorrow with a better regex (that counts possible multiline func definitions).

Thanks a lot for your reviews! 👍

@JelleZijlstra

Copy link
Copy Markdown
Member

protip: reformat the codebase with black --line-length=999999999 to make greps and codemods simpler.

@github-actions

This comment has been minimized.

@sobolevn

Copy link
Copy Markdown
Member Author

Idea: maybe we don't need to type assertRaises?

Some people might send some intentionally bad arguments 🤔

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn

Copy link
Copy Markdown
Member Author

@srittau @JelleZijlstra friendly ping 😉

@srittau
srittau merged commit 20508d0 into python:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants