Skip to content

Use Literal and __all__ in binhex - #6845

Merged
srittau merged 3 commits into
python:masterfrom
sobolevn:patch-74
Jan 9, 2022
Merged

srittau merged 3 commits into
python:masterfrom
sobolevn:patch-74

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 6, 2022

Copy link
Copy Markdown
Member

No description provided.

@github-actions

This comment has been minimized.

@sobolevn

sobolevn commented Jan 6, 2022

Copy link
Copy Markdown
Member Author
 Stub: at line 10
Literal[b'\\x90']
Runtime:
b'\x90'

@hauntsaninja is it valid? Or is it a bug?

@hauntsaninja

Copy link
Copy Markdown
Collaborator

Seems like a bug

@sobolevn

sobolevn commented Jan 7, 2022

Copy link
Copy Markdown
Member Author

@hauntsaninja should this be closed? I guess it can wait for 0.931 release

@JelleZijlstra JelleZijlstra reopened this Jan 7, 2022
@github-actions

This comment has been minimized.

@sobolevn

sobolevn commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Rebased, now Literal[bytes] should work!

@github-actions

github-actions Bot commented Jan 9, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn

sobolevn commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Awesome!

@srittau
srittau merged commit bb6a6e3 into python:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants