Repository navigation
Use lowercase set, frozenset and deque where possible - #6346
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
added a commit
to JukkaL/typeshed
that referenced
this pull request
Dec 13, 2021
`collections.abc.Set` was accidentally replaced with `set` in python#6346. The prior is an alias to `typing.AbstractSet`, instead of `builtins.set`. Since `collections.abc.Set` is easily confused with `typing.Set`, it seems clearer to use `typing.AbstractSet` here.
|
I'm trying to understand the rationale behind doing this for the return types in |
Collaborator
|
|
|
I am indeed referring to |
Member
|
If you have a proposed change to make, better to make an issue (or PR) instead of posting on a change from five years ago; lots has changed in typeshed since then. |
|
I guess I thought it was more likely I had misunderstood something 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solely consists of changing
typing.Settoset,typing.FrozenSettofrozenset, andtyping.Dequetodeque. It should hopefully have no mypy_primer diff at all.