Reduce use of `Any` in builtins by AlexWaygood · Pull Request #6292 · python/typeshed

AlexWaygood · 2021-11-14T11:51:48Z

An attempt to reduce the use of Any in builtins. A little experimental; this will likely be revised based on the output from mypy primer.

AlexWaygood · 2021-11-14T12:38:56Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

AlexWaygood · 2021-11-14T13:50:34Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

Ditto for vars()

AlexWaygood · 2021-11-14T14:04:40Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

Ditto for __import__

AlexWaygood · 2021-11-14T14:17:41Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

Ditto for eval

AlexWaygood · 2021-11-14T14:30:08Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

Ditto for object.__getattribute__

srittau

I like the general idea of this PR. I noticed one thing below and will comment in more depth, once you've whittled down the primer output and mark this as ready to review.

AlexWaygood · 2021-11-14T15:07:07Z

Reverting the change to getattr's return type, as that seems to be responsible for a lot of the new errors, and I'm interested in seeing the mypy_primer diff without it.

Ditto for globals()

JelleZijlstra · 2021-11-14T15:31:39Z

Not sure what's going on in pytest (affected code is here: https://github.com/pytest-dev/pytest/blob/main/src/_pytest/fixtures.py#L290). Maybe mypy just reordered its module processing for some reason.

Would've been weird to have eval() return Any and exec() return object.

srittau

A few more remarks below. The rest LGTM.

… into cut-down-anys

github-actions · 2021-11-14T16:43:33Z

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra

As discussed [here](python#6292 (comment)) (cc: @JelleZijlstra)

Reverts regressions introduced by python#6292. Fixes python#6661.

Reverts regressions introduced by #6292. Fixes #6661.

Reduce use of Any in builtins

bb23fc4

This comment has been minimized.

Sign in to view

Remove more Anys

262b52a

This comment has been minimized.

Sign in to view

Revert change to getattr return type

f5cde74

This comment has been minimized.

Sign in to view

Revert getattr return changes for realz this time

6a35ca2

This comment has been minimized.

Sign in to view

Revert changes to vars() return type

87c4fcc

This comment has been minimized.

Sign in to view

Revert change to __import__ return type

9b709ef

This comment has been minimized.

Sign in to view

Revert changes to eval return type

ce956d3

This comment has been minimized.

Sign in to view

Revert change to return type of object.__getattribute__

8209d19

JelleZijlstra reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

JelleZijlstra reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

JelleZijlstra reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi

JelleZijlstra reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

This comment has been minimized.

Sign in to view

srittau reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

Address review

69060a9

This comment has been minimized.

Sign in to view

Revert change to globals() return type

dca0a24

AlexWaygood added 3 commits November 14, 2021 15:19

dict invariance applies to exec as well as eval

6dee198

Revert changes to locals so Sebastian doesn't complain ;)

ae18109

Add comment

a0d5af5

This comment has been minimized.

Sign in to view

Apply black

bd5455f

This comment has been minimized.

Sign in to view

srittau reviewed Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

This comment has been minimized.

Sign in to view

Revert change to dict.fromkeys

e37753b

This comment has been minimized.

Sign in to view

AlexWaygood requested a review from srittau November 14, 2021 15:49

Revert return type of exec()

4ef36d3

Would've been weird to have eval() return Any and exec() return object.

srittau requested changes Nov 14, 2021

View reviewed changes

Comment thread stdlib/builtins.pyi Outdated

Comment thread stdlib/builtins.pyi Outdated

Comment thread stdlib/builtins.pyi Outdated

This comment has been minimized.

Sign in to view

AlexWaygood added 2 commits November 14, 2021 16:29

Address review

570c014

Merge branch 'cut-down-anys' of https://github.com/AlexWaygood/typeshed…

fbd307c

… into cut-down-anys

AlexWaygood requested a review from srittau November 14, 2021 16:44

srittau approved these changes Nov 14, 2021

View reviewed changes

JelleZijlstra approved these changes Nov 14, 2021

View reviewed changes

JelleZijlstra merged commit 88f86a0 into python:master Nov 14, 2021

AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Nov 14, 2021

Simplify stub for iter()

f40c69c

As discussed [here](python#6292 (comment)) (cc: @JelleZijlstra)

AlexWaygood mentioned this pull request Nov 14, 2021

Simplify stub for iter() #6297

Closed

AlexWaygood deleted the cut-down-anys branch November 15, 2021 00:16

AlexWaygood mentioned this pull request Nov 16, 2021

Resolve builtins/importlib inconsistencies #6310

Merged

AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Dec 22, 2021

Fix 'object.__reduce__'

0bd5883

Reverts regressions introduced by python#6292. Fixes python#6661.

AlexWaygood mentioned this pull request Dec 22, 2021

Fix object.__reduce__ #6662

Merged

JelleZijlstra pushed a commit that referenced this pull request Dec 22, 2021

Fix 'object.__reduce__' (#6662)

1ec2387

Reverts regressions introduced by #6292. Fixes #6661.

Conversation

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

AlexWaygood commented Nov 14, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

JelleZijlstra commented Nov 14, 2021

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

srittau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Nov 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants