Skip to content

Make logging.StreamHandler generic over stream #5681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 1 commit into from
Jun 23, 2021
Merged

Make logging.StreamHandler generic over stream #5681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions stdlib/logging/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ from io import TextIOWrapper
from string import Template
from time import struct_time
from types import FrameType, TracebackType
from typing import Any, ClassVar, Optional, Pattern, Tuple, Type, Union
from typing import Any, ClassVar, Generic, Optional, Pattern, TextIO, Tuple, Type, TypeVar, Union, overload

_SysExcInfoType = Union[Tuple[Type[BaseException], BaseException, Optional[TracebackType]], Tuple[None, None, None]]
_ExcInfoType = Union[None, bool, _SysExcInfoType, BaseException]
Expand Down Expand Up @@ -750,17 +750,21 @@ def setLoggerClass(klass: Type[Logger]) -> None: ...
def captureWarnings(capture: bool) -> None: ...
def setLogRecordFactory(factory: Callable[..., LogRecord]) -> None: ...

lastResort: Optional[StreamHandler]
lastResort: StreamHandler[Any] | None

class StreamHandler(Handler):
stream: SupportsWrite[str] # undocumented
_StreamT = TypeVar("_StreamT", bound=SupportsWrite[str])

class StreamHandler(Handler, Generic[_StreamT]):
stream: _StreamT # undocumented
terminator: str
def __init__(self, stream: SupportsWrite[str] | None = ...) -> None: ...
@overload
def __init__(self: StreamHandler[TextIO], stream: None = ...) -> None: ...
@overload
def __init__(self: StreamHandler[_StreamT], stream: _StreamT) -> None: ...
if sys.version_info >= (3, 7):
def setStream(self, stream: SupportsWrite[str]) -> SupportsWrite[str] | None: ...
def setStream(self, stream: _StreamT) -> _StreamT | None: ...

class FileHandler(StreamHandler):
stream: TextIOWrapper # undocumented
class FileHandler(StreamHandler[TextIOWrapper]):
baseFilename: str # undocumented
mode: str # undocumented
encoding: str | None # undocumented
Expand All @@ -772,9 +776,7 @@ class FileHandler(StreamHandler):
) -> None: ...
else:
def __init__(self, filename: StrPath, mode: str = ..., encoding: str | None = ..., delay: bool = ...) -> None: ...
def _open(self) -> TextIOWrapper: ...
if sys.version_info >= (3, 7):
def setStream(self, stream: TextIOWrapper) -> TextIOWrapper | None: ... # type: ignore
def _open(self) -> TextIOWrapper: ... # undocumented

class NullHandler(Handler): ...

Expand Down