Repository navigation
Bump pyright to 1.1.126, enable 3.10 testing - #5153
Merged
Merged
Conversation
jakebailey
changed the title
Member
|
Thanks for this! Stubtest is failing in CI because of changes to its own source; I might have some time later today to update the whitelists accordingly (cc @hauntsaninja). |
Contributor
Author
|
Ah, I was wondering why it'd break but HEAD is okay. No worries. |
Collaborator
|
Oh right, sorry. Forgot that we unpinned mypy because of modular typeshed. (Can pick up tonight/tomorrow if you don't get to it first) |
Collaborator
|
#5155 for fixing CI |
Contributor
Author
|
I think things are working now; I'm unfortunately not an org member so can't click the button myself. 🙂 |
JelleZijlstra
approved these changes
Mar 30, 2021
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
There was a problem hiding this comment.
I'll merge once CI is all green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyright hasn't been updated in a while; update it.
Enable testing 3.10 with pyright; there have been some changes in typeshed recently for 3.10 that should be getting checked. We don't actually need 3.10 to be out to check these.