Repository navigation
tkinter: type hints for Menu add_foo and insert_foo methods - #4903
Merged
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine.git)
+ porcupine/plugins/reload.py:35: error: Argument 1 to "insert_command" of "Menu" has incompatible type "object"; expected "Union[str, int]" [arg-type]
|
Collaborator
Author
|
In the Edit: To clarify, the type is |
Akuli
added a commit
to Akuli/porcupine
that referenced
this pull request
Jan 5, 2021
Collaborator
|
The annotation seems fine to me. I think it's better to add an explicit annotation in porcupine. I think this should work: index: Union[int, str] = separator_locations[0] if separator_locations else 'end' |
Collaborator
Author
|
The Porcupine commit that shows up above adds that |
Collaborator
Author
|
I cherry-picked it to porcupine master which is what mypy_primer uses. Should no longer cause error |
Akuli
added a commit
to Akuli/porcupine
that referenced
this pull request
Jan 5, 2021
srittau
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated with script:
Details