Skip to content

Enable --disallow-subclassing-any - #3591

Merged
JelleZijlstra merged 3 commits into
python:masterfrom
srittau:disallow-subclassing-any
Jan 8, 2020
Merged

JelleZijlstra merged 3 commits into
python:masterfrom
srittau:disallow-subclassing-any

Conversation

@srittau

@srittau srittau commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator

Closes: #1446

@JelleZijlstra

Copy link
Copy Markdown
Member

There are a few other issues in 2.7:

third_party/2/fb303/FacebookService.pyi:61: error: Class cannot subclass 'TProcessor' (has type 'Any')
third_party/2/scribe/scribe.pyi:16: error: Class cannot subclass 'TProcessor' (has type 'Any')

@srittau

srittau commented Jan 8, 2020

Copy link
Copy Markdown
Collaborator Author

I really need to get in the habit of running at least the mypy tests in full before submitting. The checks now pass.

@JelleZijlstra

Copy link
Copy Markdown
Member

What's been helpful for me is enabling Travis CI on my own fork of typeshed. That way, after I push a commit to a branch Travis automatically runs the tests and emails me once they complete.

@JelleZijlstra
JelleZijlstra merged commit fdeae5d into python:master Jan 8, 2020
@srittau
srittau deleted the disallow-subclassing-any branch January 8, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Classes should not inherit from Any

2 participants