Skip to content

Add typings for bool __{r,}{and,or,xor}__ - #1795

Merged
JelleZijlstra merged 1 commit into
python:masterfrom
asottile:bool_LSV_violation
Dec 21, 2017
Merged

JelleZijlstra merged 1 commit into
python:masterfrom
asottile:bool_LSV_violation

Conversation

@asottile

Copy link
Copy Markdown
Contributor

Resolves #1793

@asottile

Copy link
Copy Markdown
Contributor Author

I want to add a test for this, but I'm not sure where to do that -- in mypy?

@JelleZijlstra

Copy link
Copy Markdown
Member

Typeshed itself doesn't yet support test cases for individual stubs (there's an open issue for that).

For now, you can show a test program in a comment here and the mypy output to show that it works correctly.

@asottile

Copy link
Copy Markdown
Contributor Author

Cool, the short test program is included in the issue itself

@JelleZijlstra
JelleZijlstra merged commit 0304421 into python:master Dec 21, 2017
@asottile
asottile deleted the bool_LSV_violation branch February 16, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants