Repository navigation
Allow default as keyword arg to os.environ.{get,pop} - #15194
Merged
AlexWaygood merged 1 commit intoDec 31, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
RasmusNygren
force-pushed
the
allow-default-keyword-for-environ
branch
from
December 30, 2025 20:25
8f62687 to
e8d4cf7
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pyodide (https://github.com/pyodide/pyodide)
- pyodide-build/pyodide_build/xbuildenv_releases.py:220: error: No overload variant of "get" of "Mapping" matches argument types "str", "str" [call-overload]
- pyodide-build/pyodide_build/xbuildenv_releases.py:220: note: Possible overload variants:
- pyodide-build/pyodide_build/xbuildenv_releases.py:220: note: def get(self, str, /) -> str | None
- pyodide-build/pyodide_build/xbuildenv_releases.py:220: note: def get(self, str, str, /) -> str
- pyodide-build/pyodide_build/xbuildenv_releases.py:220: note: def [_T] get(self, str, _T, /) -> str | _T
|
Member
|
Thanks! It looks like all the other stdlib classes that override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15193