Repository navigation
[PyMySQL] Fix stubs for pymysql.connections.Connection.__init__ - #14724
Merged
brianschubert merged 5 commits intoSep 15, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Linking #14718 for visibility there |
This comment has been minimized.
This comment has been minimized.
brianschubert
requested changes
Sep 15, 2025
brianschubert
left a comment
brianschubert
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Unfortunately this has a behavior change (see below), but there's an easy fix
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be what it is at runtime: https://github.com/PyMySQL/PyMySQL/blob/d7bb777e503d82bf2496113f07dd4ab249615efc/pymysql/connections.py#L188C9-L188C20