Repository navigation
covariant warnings.catch_warnings type-parameter with default - #13675
Merged
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pytest (https://github.com/pytest-dev/pytest)
+ src/_pytest/recwarn.py:170: error: Unused "type: ignore" comment [unused-ignore]
+ src/_pytest/recwarn.py:229: error: Return type "WarningsRecorder" of "__enter__" incompatible with return type "Optional[list[WarningMessage]]" in supertype "catch_warnings" [override]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the type parameter of
warnings.catch_warningsin two ways:covariant=True— as it's only used within output positions — and renamed it accordinglydefaultto its upperboundso that it isn't required anymore to pass a type-argument to a class that is not subscriptable at runtimeThe invariance was causing issues within the numpy stubs for a generic a subclass:
https://github.com/numpy/numpy/blob/0aafd8553a986c7d39dde489ac5d42e53322b090/numpy/testing/_private/utils.pyi#L138-L147 to be precise