Repository navigation
[cffi] Fix a few argument types for C code - #13661
Merged
Merged
Conversation
srittau
commented
Mar 18, 2025
srittau
commented
Collaborator
- CLibrary.close_lib() doesn't take any arguments.
- FFI.typeof() only takes positional arguments.
* CLibrary.close_lib() doesn't take any arguments. * FFI.typeof() only takes positional arguments.
srittau
changed the title
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Mar 18, 2025
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
IIRC Serhiy made some improvements to inspect.signature() and/or argument clinic in Python 3.13, which is probably why these are being picked up when stubtest is run on 3.13 but not otherwise. (And this is obviously a good argument for running stubtest with py313 if possible!)
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
* CLibrary.close_lib() doesn't take any arguments. * FFI.typeof() only takes positional arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.