Repository navigation
add email.__all__ - #13047
Merged
Merged
add email.__all__#13047
email.__all__#13047Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Ah, upon re-reading I believe the problem is with auto-suggestions by tools that pick up the stubs. Hm. |
Contributor
Author
|
What happens if we just go for accuracy, then? |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Merged
srittau
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read through #6523. If there's a reason why we shouldn't work around the issue this way until a better option is available, it wasn't clear to me from that thread.