Repository navigation
Add missing constants to flask-cors stubs - #12585
Conversation
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
left a comment
There was a problem hiding this comment.
Thanks!
(At some point, the constants could be converted to Final strings that are assigned the actual value, but that can wait for another PR.)
Thanks! |
|
The current gold standard for constants is to use ANSWER_QUESTION_OF_LIFE: Final = 42
SOME_RANDOM_CONSTANT: Final[int]We'd certainly appreciate a PR changing the flask-cors constants accordingly. |
|
@srittau Thanks for the explanation, I'll try to update soon!) |
No description provided.