Repository navigation
Remove obsolete mypy bug workaround in abspath() - #12208
Conversation
This comment has been minimized.
This comment has been minimized.
|
Can we also get rid of the similar overloads in Lines 236 to 246 in c709686 |
This comment has been minimized.
This comment has been minimized.
|
Okay it looks like weird things happen if you try to pass an object typed as |
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM. From the mypy_primer result when we tried to do similarly with the re.pyi overloads, I guess you might run into false positives if you tried to pass an object typed as PathLike[Any] into one of these functions. But I'd guess that's pretty rare. By far the most common PathLike object around is pathlib.Path, which is PathLike[str] rather than PathLike[Any].
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
)" This reverts commit 271df8e.
No description provided.