Repository navigation
Don't pretend EnumMeta inherits from ABCMeta - #10577
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
marked this pull request as ready for review
August 14, 2023 17:02
AlexWaygood
marked this pull request as draft
August 14, 2023 17:03
AlexWaygood
marked this pull request as ready for review
August 14, 2023 17:39
AlexWaygood
marked this pull request as draft
August 14, 2023 17:39
Member
Author
|
I'm running the full mypy test suite against this PR just to make sure it doesn't break any mypy tests: |
Member
Author
|
It doesn't look like this causes any issues for mypy — we've got a clean bill of health on AlexWaygood/mypy#10! |
AlexWaygood
marked this pull request as ready for review
August 14, 2023 18:14
hauntsaninja
approved these changes
Aug 14, 2023
hauntsaninja
left a comment
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure I understand the history here, but if alex_primer says things are green, this looks great to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes python/mypy#15870