Openpyxl typeshed errors #9836

Activity

1. srittau commented on Mar 6, 2023

   

   srittau

   on Mar 6, 2023

   Collaborator

   More actions

   #9764 actually made load_workbook() return a Workbook. Previously, it returned Any. The problem is that wb.active can return other workbook children (and even None), not only Worksheets. The easiest way to work around this problem is to use:

   wb = openpyxl.load_workbook(path)
   ws = wb.active
   assert isinstance(ws, Worksheet)
   header = [cell.value for cell in ws[1]]  # line 120

   Cc @mynhardtburger

   👍React with 👍1Reacted by Avasam
2. Avasam commented on Mar 7, 2023

   

   Avasam

   on Mar 7, 2023

   Last edited by Avasam

   SponsorCollaborator

   More actions

   +1 what @srittau said.
   Even in #9511 I made load_workbook return a Workbook, the type comes from: https://foss.heptapod.net/openpyxl/openpyxl/-/blob/branch/3.1/openpyxl/reader/workbook.py#L31
3. tritemio commented on Mar 8, 2023

   

   tritemio

   on Mar 8, 2023

   Author

   More actions

   Thanks for the quick answer. I'll apply the workaround to fix the code.

   Maybe it could a good idea to write in the changelog that the type stubs are now more accurate and this may require changes to existing code bases that implicitly relied on wb.active to be Any. A link to the fix in this thread could also be useful.
4. srittau commented on Mar 8, 2023

   

   srittau

   on Mar 8, 2023

   Collaborator

   More actions

   @tritemio Unfortunately, our changelogs are currently auto-generated from git commit messages, which is why they are a bit messy and we can't edit them retroactively.
5. AlbertoPuritano commented on Mar 9, 2023

   

   AlbertoPuritano

   on Mar 9, 2023

   Last edited by AlbertoPuritano

   More actions

   #9764 actually made load_workbook() return a Workbook. Previously, it returned Any. The problem is that wb.active can return other workbook children (and even None), not only Worksheets. The easiest way to work around this problem is to use:

   wb = openpyxl.load_workbook(path)
   ws = wb.active
   assert isinstance(ws, Worksheet)
   header = [cell.value for cell in ws[1]]  # line 120

   Cc @mynhardtburger

   Hello, apparently using the assert doesn't prevent mypy from reporting the error.. type hinting doesn't do much either, do you have any other solutions?
6. srittau commented on Jun 12, 2023

   

   srittau

   on Jun 12, 2023

   Collaborator

   More actions

   I think the problems with wb.active have been explained. There isn't a better solution at the moment, until something like python/typing#566 becomes available.
7. srittau

   closed this as not plannedon Jun 12, 2023