Skip to content

stubsabot: find_first_release_with_py_typed() doesn't work when only the latest release has py.typed #9759

Closed
#9760
Closed
stubsabot: find_first_release_with_py_typed() doesn't work when only the latest release has py.typed#9759
#9760

Description

@Akuli
Akuli
opened on Feb 19, 2023

typeshed/scripts/stubsabot.py

Lines 173 to 180 in da9366d

async def find_first_release_with_py_typed(pypi_info: PypiInfo, *, session: aiohttp.ClientSession) -> PypiReleaseDownload | None:
release_iter = pypi_info.releases_in_descending_order()
# If the latest release is not py.typed, assume none are.
if not (await release_contains_py_typed(release := next(release_iter), session=session)):
return None
first_release_with_py_typed: PypiReleaseDownload | None = None
while await release_contains_py_typed(release := next(release_iter), session=session):

This function returns None if the latest release has py.typed and other releases don't. This is because the first next(release_iter) consumes the first release and essentially hides it from the rest of this function.

Broken in #9754

Activity

  1. AlexWaygood commented on Feb 19, 2023

    @AlexWaygood
    AlexWaygood
    on Feb 19, 2023
    Member

    cc. @Avasam

  2. AlexWaygood
    closed this as completedin #9760on Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions