Repository navigation
Remove emoji stubs (not before May 2023) #8760
Description
With carpedm20/emoji#166 merged using the stubs previously contributed to typeshed, the latest release now next release should include type hints. Seems 2.1.0 was tagged directly before type hints being merged.
Activity
[-]Remove emoji from typeshed[/-][+]Remove emoji stubs (not before ?)[/+]AlexWaygood commentedon Sep 17, 2022
As per our policy, we'll want to wait until the library has shipped with a
py.typedfile for at least six months before removing the stubs from typeshed, but this is great to hear! :)kkirsche commentedon Oct 12, 2022
Emoji 2.1.0 was released on September 17, 2022.
https://pypi.org/project/emoji/2.1.0/
When in front of a computer, I'll confirm that it has the py.typed marker. If so, this should give us a date for when this should be removed.
I'll plan to file a separate issue for automated
py.typeddetection to gauge interest in this type of automation / integration.AlexWaygood commentedon Oct 12, 2022
Stubsabot already does that for us (see, e.g., #8746). If there's already been an
emojirelease that has apy.typedfile, that indicates that there's a bug in stubsabot.AlexWaygood commentedon Oct 12, 2022
There doesn't appear to be a bug in stubsabot. The
masterbranch has thepy.typedmarker, but the latest release, 2.1.0, released on September 17, does not have thepy.typedmarker.hauntsaninja commentedon Oct 12, 2022
Probably a bug in emoji packaging
Avasam commentedon Oct 14, 2022
It is a bug in emoji. The
py.typedmarker isn't added to the package carpedm20/emoji#239AlexWaygood commentedon Nov 1, 2022
We now have a release with a
py.typedfile![-]Remove emoji stubs (not before ?)[/-][+]Remove emoji stubs (not before May 2023)[/+]Remove `emoji` stubs, refs #8760
Remove `emoji` stubs (#10160)