Skip to content

Checks don't run on stubsabot PRs #8434

Closed

Description

@hauntsaninja

However, you can trigger them by manually closing and re-opening.

This isn't an ideal state of things. There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

Activity

  1. AlexWaygood commented on Sep 17, 2022

    @AlexWaygood
    Member

    There's a list of possible workarounds here: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#workarounds-to-trigger-further-workflow-runs

    I like the sound of the last option on this list best: creating a minimal GitHub App that would generate tokens for use with GitHub Actions. The only downside I can see is that the app would have to be associated with a maintainer's personal account, so if the maintainer stopped being active for whatever reason, it might be difficult for other maintainers to get access to the app. I think it would still be better than the current state of affairs, however -- if others agree, I'm happy to set up a GitHub App to do this?

  2. AlexWaygood commented on Sep 17, 2022

    @AlexWaygood
    Member

    Oh, actually, the ssh key option would maybe be better. I was worried that it wouldn't work so well, because of the fact that it only works with push events, rather than pull_request events. But that shouldn't be an issue: stubsabot creates new branches on the typeshed fork, and we can easily adjust the tests.yml workflow so that it runs on push events for any branches starting with stubsabot/. The ssh option is used by oddbird/MetaDeploy here, and they seem pretty happy about it (they wrote a nice blog post about their automated PRs for uprading dependencies here.)

  3. added a commit that references this issue on Oct 4, 2022
    ee995b2
  4. added a commit that references this issue on Oct 4, 2022
    5cb7ef1
  5. srittau commented on Jul 11, 2026

    @srittau
    Collaborator

    GitHub recently added a button that allows us to run the tests with one click. Still not ideal (I would prefer to be able to allowlist stubsabot), but I don't think we need a more complicated solution necessarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions