Skip to content

Remove xxhash types (not before April 2023) #7142

Closed

Description

@faresbakhit

ifduyue/python-xxhash added type hints to master the last month (here in #4689), however the latest release doesn't ship with __init__.pyi nor py.typed. so wait until xxhash's next release and remove ./stubs/xxhash from here?

Activity

  1. JelleZijlstra commented on Feb 6, 2022

    @JelleZijlstra
    Member

    Thanks! Our rule is to remove the stubs 6 months after the first release that ships stubs.

  2. changed the title [-]Remove xxhash types[/-] [+]Remove xxhash types (not before ?)[/+] on Feb 22, 2022
  3. srittau commented on Mar 14, 2022

    @srittau
    Collaborator

    xxhash doesn't seem to ship with py.typed, and I can't find any mention of py.typed in the repository either. I am going to close this until xxhash adds support for type hints.

  4. hauntsaninja commented on Mar 14, 2022

    @hauntsaninja
    Collaborator

    Sort of seems the intention was to add a py.typed though (ifduyue/python-xxhash#51 talks about PEP 561), so could mention it to the upstream project if anyone is so inclined.

  5. changed the title [-]Remove xxhash types (not before ?)[/-] [+]Remove xxhash types (not before April 2023)[/+] on Oct 20, 2022
  6. AlexWaygood commented on Oct 20, 2022

    @AlexWaygood
    Member

    Upstream just cut a release with a py.typed file: #8935

  7. added a commit that references this issue on Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stubs: removalPending removal of third-party distributions

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions