Skip to content

add third part package peewee #4261

Closed
Closed

Description

@trim21

https://github.com/coleifer/peewee

I'd like to start adding this package stubs to typeshed. I'm creating this issue to see if it's ok.

(I'm not a native English speaker, sorry for my poor English)

Activity

  1. srittau commented on Jun 24, 2020

    @srittau
    Collaborator

    Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.

  2. trim21 commented on Jun 24, 2020

    @trim21
    ContributorAuthor
  3. JelleZijlstra commented on Jun 24, 2020

    @JelleZijlstra
    Member

    That's a while ago, so it might be worth asking again.

  4. dargueta commented on Nov 8, 2020

    @dargueta
    Contributor

    They've refused twice more since then, I just looked. Rather vehemently, I might add.

  5. JukkaL commented on Nov 10, 2020

    @JukkaL
    Contributor

    I think that in this case adding stubs to typeshed seems reasonable. The project maintainers don't want to deal with type annotations but aren't opposed to hosting stubs elsewhere, as far as I can tell.

  6. dargueta commented on Nov 11, 2020

    @dargueta
    Contributor

    @trim21 I've gotten started on this. I'll open a PR on typeshed and you can contribute if you want to help. It's quite the task 😬

  7. dargueta commented on Nov 18, 2020

    @dargueta
    Contributor

    Here's the PR if anyone wants to help out. It's nowhere near done yet -- peewee is a single file with > 7.7 KLOC

  8. trim21 commented on Nov 18, 2020

    @trim21
    ContributorAuthor

    I didn't use peewee anymore, thanks everyone and please checkout @dargueta 's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions