You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.
------------------ Original ------------------
From: Sebastian Rittau <notifications@github.com>
Date: Wed,Jun 24,2020 4:15 PM
To: python/typeshed <typeshed@noreply.github.com>
Cc: Trim21 <github@trim21.me>, Author <author@noreply.github.com>
Subject: Re: [python/typeshed] add third part package peewee (#4261)
Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
I think that in this case adding stubs to typeshed seems reasonable. The project maintainers don't want to deal with type annotations but aren't opposed to hosting stubs elsewhere, as far as I can tell.
Activity
srittau commentedon Jun 24, 2020
Stubs for third-party libraries are definitely welcome in typeshed. That said, did you contact the peewee developers to see whether they are interested in adding stubs directly to the package? We are glad to help and review stubs in other repositories as well.
trim21 commentedon Jun 24, 2020
JelleZijlstra commentedon Jun 24, 2020
That's a while ago, so it might be worth asking again.
dargueta commentedon Nov 8, 2020
They've refused twice more since then, I just looked. Rather vehemently, I might add.
JukkaL commentedon Nov 10, 2020
I think that in this case adding stubs to typeshed seems reasonable. The project maintainers don't want to deal with type annotations but aren't opposed to hosting stubs elsewhere, as far as I can tell.
dargueta commentedon Nov 11, 2020
@trim21 I've gotten started on this. I'll open a PR on typeshed and you can contribute if you want to help. It's quite the task 😬
dargueta commentedon Nov 18, 2020
Here's the PR if anyone wants to help out. It's nowhere near done yet -- peewee is a single file with > 7.7 KLOC
trim21 commentedon Nov 18, 2020
I didn't use peewee anymore, thanks everyone and please checkout @dargueta 's PR.