Skip to content

socket.create_connection source_address should be optional #4116

Closed

Description

@bwelling
def create_connection(address: Tuple[Optional[str], int],
                      timeout: Optional[float] = ...,
                      source_address: Tuple[Union[bytearray, bytes, Text], int] = ...) -> socket: ...

The source_address field should be marked as Optional, as it defaults to None.

Activity

  1. srittau commented on May 28, 2020

    @srittau
    Collaborator

    Indeed. PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions