You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add join function in shlex module (new in 3.8) #3430
Adding join would be quite simple, and would probably look a bit like this:
defjoin(s: List[str]) ->str: ...
I have not opened a PR yet because I wonder if this is something that you would want to add or not, because saying that join does not exist is true for python3.7 and lower. Surely there must be precedent, but I could not find an example of this in the issues yet.
Activity
utkarsh2102 commentedon Oct 31, 2019
Hi,
With #3319 already in progress, I think you could open a PR with:
if sys.version_info >= (3, 8)::)Also, @srittau would know better :)
srittau commentedon Oct 31, 2019
Thanks for the report.
shlex.join()was added in #3358.