Skip to content

Turn --disallow-any-generics on when checking stubs with mypy #3267

Closed

Description

@ilevkivskyi

I have noticed several people recently forgot to specify type arguments. Should we try enforcing this?

Activity

  1. gvanrossum commented on Sep 26, 2019

    @gvanrossum
    Member

    +1, assuming we don't have to fix 100s of places...

  2. srittau commented on Sep 26, 2019

    @srittau
    Collaborator

    More strictness is a good thing for typeshed, in my opinion.

  3. ilevkivskyi commented on Sep 27, 2019

    @ilevkivskyi
    MemberAuthor

    I actually just tried this and it causes around 400 errors. On one hand this is not too many to do this in general, on other hand it is probably too many to do this right now.

  4. gvanrossum commented on Sep 27, 2019

    @gvanrossum
    Member
  5. ilevkivskyi commented on Sep 28, 2019

    @ilevkivskyi
    MemberAuthor

    Could we incrementally fix those errors? Even if some more of the same type of errors appear it would be less work to fix the final batch.

    This is a good idea. @srittau what do you think about splitting the work, will you have time/energy? Also maybe @JelleZijlstra ?

  6. srittau commented on Sep 28, 2019

    @srittau
    Collaborator

    Good idea indeed. I'll look into it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stubs: improvementImprove/refactor existing annotations, other stubs issues

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions