Support TextIOWrapper.reconfigure() #3049

Activity

1. srittau

   added

   size-medium

   stubs: false positiveType checkers report false errorsType checkers report false errors

   on Jun 11, 2019
2. srittau commented on Jun 11, 2019

   

   srittau

   on Jun 11, 2019

   Collaborator

   More actions

   Currently sys.stdin et al. are typed as TextIO, not TextIOWrapper. This would need to be changed as well, although I am not sure that this does not cause complications. But adding TextIOWrapper.reconfigure() would be welcome in any case.
3. serhiy-storchaka commented on May 14, 2020

   

   serhiy-storchaka

   on May 14, 2020

   Member

   More actions

   For the following code

   import sys, io
   
   if isinstance(sys.stdout, io.TextIOWrapper) and sys.version_info >= (3, 7):
       sys.stdout.reconfigure(errors="replace")

   I get the error:

   reconfigure37.py:4: error: "TextIOWrapper" has no attribute "reconfigure"
   

   MyPy understand that sys.stdout is a TextIOWrapper instance.
4. serhiy-storchaka commented on May 14, 2020

   

   serhiy-storchaka

   on May 14, 2020

   Member

   More actions

   What is worse -- I cannot silence the error by adding # type: ignore, because on Python 3.6 I get error: unused 'type: ignore' comment.
5. grantwwu commented on May 14, 2020

   

   grantwwu

   on May 14, 2020

   Author

   More actions

   I haven't touched MyPy in many months but your platform check might be too complex for https://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks to understand. Try splitting it into two ifs?
6. srittau commented on May 14, 2020

   

   srittau

   on May 14, 2020

   Collaborator

   More actions

   FWIW, I just checked the following with mypy 0.770 using --warn-unused-ignores under both Python 3.6.9 and 3.7.4 and it works or me:

   import sys, io
   
   if isinstance(sys.stdout, io.TextIOWrapper) and sys.version_info >= (3, 7):
       sys.stdout.reconfigure(errors="replace")  # type: ignore

   That said, we'll gladly accept a PR that adds TextIOWrapper.reconfigure() :)
7. serhiy-storchaka commented on May 18, 2020

   

   serhiy-storchaka

   on May 18, 2020

   Member

   More actions

   It is the same if split on two ifs.

   😕React with 😕1Reacted by Grant Wu
8. srittau

   closed this as completedin #4035on May 19, 2020
9. adam-grant-hendry

   added a commit that references this issue on Jul 10, 2023

   fix(out.py): `TextIOWrapper.reconfigure` typing

   ...

   f43ea03
10. adam-grant-hendry

    added 2 commits that reference this issue on Jul 25, 2023

    fix(out.py): `TextIOWrapper.reconfigure` typing

    ...

    821fa56

    fix(out.py): `TextIOWrapper.reconfigure` typing

    ...

    e4611e2
11. Lee-W

    added a commit that references this issue on Aug 1, 2023

    fix(out.py): `TextIOWrapper.reconfigure` typing

    ...

    0ef12d5