Skip to content

In RawConfigParser "vars: _section" should be "vars: Optional[_section]" #2847

Closed

Description

@jolaf

Methods get*() and items() of RawConfigParser and SectionProxy declare argument vars=None.

However in the stubs they're defined as vars: _section, where _section = Mapping[str, str], which effectively creates problems when inheriting from ConfigParser and trying to follow the original defaults pattern.

Probably in all these methods it should be vars: Optional[_section].

Activity

  1. srittau commented on Mar 10, 2019

    @srittau
    Collaborator

    Patches welcome!

  2. jolaf commented on Mar 11, 2019

    @jolaf
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions