Skip to content

int.__new__ needs a stub #2686

Closed
Closed
int.__new__ needs a stub#2686
Labels
stubs: incompleteAnnotations or sub-modules missing from an existing package or module

Description

@DarwinAwardWinner
DarwinAwardWinner
opened on Dec 12, 2018

It seems that int doesn't have a method stub for __new__, which causes mypy to complain on code that attempts to subclass int. Unfortunately, I'm not sure exactly how to write this stub. If someone can give me some guidance, I can try to write a pull request.

Activity

  1. sproshev commented on Dec 12, 2018

    @sproshev
    sproshev
    on Dec 12, 2018
    Contributor

    int.__new__ had been added in #1352 but then reverted in #1464

  2. DarwinAwardWinner commented on Dec 12, 2018

    @DarwinAwardWinner
    DarwinAwardWinner
    on Dec 12, 2018
    ContributorAuthor

    So I guess it's not possible to add a stub for int.__new__ without breaking other things? Does this mean I just need to use # type: ignore on the call to super(...).__new__() when subclassing int?

  3. srittau
    added
    stubs: false positiveType checkers report false errors
    size-small
    on Dec 12, 2018

  4. Bhargavasomu commented on Jan 14, 2019

    @Bhargavasomu
    Bhargavasomu
    on Jan 14, 2019

    I am experiencing the same issue with bytes too.

  5. sproshev commented on Jan 14, 2019

    @sproshev
    sproshev
    on Jan 14, 2019
    Contributor

    @Bhargavasomu see #2630

  6. srittau
    added
    stubs: incompleteAnnotations or sub-modules missing from an existing package or module
    and removed
    stubs: false positiveType checkers report false errors
    on Sep 17, 2020
  7. srittau
    added a commit that references this issue on Sep 17, 2020

    Use __new__ instead of __init__ for some builtin classes

    89b34c7
  8. hauntsaninja
    added a commit that references this issue on Sep 30, 2020

    Use __new__ instead of __init__ for some builtin classes (#4555)

    27dfbf6

  9. hauntsaninja commented on Sep 30, 2020

    @hauntsaninja
    hauntsaninja
    on Sep 30, 2020
    Collaborator

    Closed by #4555

  10. hauntsaninja
    closed this as completedon Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stubs: incompleteAnnotations or sub-modules missing from an existing package or module

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions