You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[CI] "pyright: Run test cases" task doesn't install apt dependencies #13973
The step "Install 3rd-party stub dependencies" of the "pyright: Run test cases" task in the tests.yml workflow doesn't install the tool.stubtest.apt_dependencies before trying to install the Python packages, leading to potential errors when they are required for building the package. Cf. #13957
That said, this makes some sense as the task in question is unrelated to stubtest. But the problem remains regardless. We should maybe move the apt_dependencies key out of tool.stubtest. Maybe rename to test_apt_dependencies and move to top level?
Activity
srittau commentedon May 9, 2025
That said, this makes some sense as the task in question is unrelated to stubtest. But the problem remains regardless. We should maybe move the
apt_dependencieskey out oftool.stubtest. Maybe rename totest_apt_dependenciesand move to top level?JelleZijlstra commentedon May 9, 2025
Bikeshed: Maybe put it in
tool.typeshed.srittau commentedon May 9, 2025
Well,
METADATA.tomlis specific to typeshed, so that would be kind of redundant.[CI] Install apt dependencies when running test cases with pyright