Repository navigation
Returning Unknown instead of Any for incomplete __getattr__ #13765
Description
I noticed we have quite a few
def __getattr__(name: str) -> Incomplete: ...Wouldn't it be better to write as
def __getattr__(name: str): ... # incompleteSo that type-checkers like Pyright in strict mode can warn about unknown types ?
Activity
srittau commentedon Apr 2, 2025
I think that was a pattern mandated in CONTRIBUTING for incomplete stubs. I think the current pattern just happened via the route
-> Any: ... # incomplete-> Incomplete: ... # incomplete-> Incomplete: ...That said, I don't have a strong preference either way.
Replace incomplete module markers
dev: Fix Pyright failures with latest version (1.1.401)
dev: Fix Pyright failures with latest version (1.1.401)