Repository navigation
incomplete type declaration at sqlite3.Connection.create_aggregate() #12141
Description
Bug report
Bug description:
The create_aggregate documentation does not specify a result type of the aggregation and even allows for multiple aggregating values per row (n_arg parameter).
However, the type declaration at dbapi2.pyi does not reflect that (comments added by me):
def create_aggregate(self, name: str, n_arg: int, aggregate_class: Callable[[], _AggregateProtocol]) -> None: ...
class _AggregateProtocol(Protocol):
def step(self, value: int, /) -> object: ... # <-- just one aggregating value of type int
def finalize(self) -> int: ... # <-- result has to be intI think that this is not correct. At least, I have working code that aggregates multiple strings into a combined one.
Also, it is in stark contrast to other, way more generic, type declarations at the same place (comments added by me):
class _AnyParamWindowAggregateClass(Protocol):
def step(self, *args: Any) -> object: ... # <-- multiple aggregating values of any type allowed
def inverse(self, *args: Any) -> object: ...
def value(self) -> _SqliteData: ...
def finalize(self) -> _SqliteData: ... # <-- result can be many more types
_SqliteData: TypeAlias = str | ReadableBuffer | int | float | NoneCPython versions tested on:
3.12
Operating systems tested on:
Windows
Activity
Eclips4 commentedon Jun 16, 2024
Hello!
This repository is intended as a CPython bug tracker, your problem is actually related to stubs which is not part of CPython; It's a part of typeshed.
I can't transfer this issue to the typeshed repo, @AlexWaygood maybe you can? 🙂
sobolevn commentedon Jun 16, 2024
This is indeed a typeshed problem. CPython documents that
finalize()returns:Looks like this protocol should be generic.
kunom commentedon Jun 16, 2024
Just to summarize my request:
stepcan take multiple arguments of several typesfinalizecan return several types