You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am asking because the python package doesn't technically ship its stub files but allows us to generate them with a python command (see vtkmodules/generate_pyi.py)
So I don't know if it respect the third point in the requirements:
the package does not ship with its own stubs or type annotations.
Their module also don't generate stub files for all .py files (and in particular for __init__.py)
Thanks for working on those stubs, and just to make sure: They are of course welcome! If you have any questions or need support, please comment in your PR.
@Gryfenfer97, I'm closing this issue for now to keep our issue tracker tidy, since the question has been answered. But that doesn't mean that your PR isn't welcome — it is, and please continue working on it! As @srittau says, please say on the PR thread if you need any help or anything is unclear :)
Activity
srittau commentedon Jul 19, 2023
Thanks for working on those stubs, and just to make sure: They are of course welcome! If you have any questions or need support, please comment in your PR.
AlexWaygood commentedon Jul 22, 2023
@Gryfenfer97, I'm closing this issue for now to keep our issue tracker tidy, since the question has been answered. But that doesn't mean that your PR isn't welcome — it is, and please continue working on it! As @srittau says, please say on the PR thread if you need any help or anything is unclear :)