Repository navigation
Check for magic number mismatch early to avoid surprises in RC stage - #153
Merged
Merged
Conversation
Contributor
Author
|
Wow, that codecov sure is a snitch. |
hugovk
approved these changes
Jul 31, 2024
Member
|
Doh, this broke releases with older versions, which don't have pycore_magic_number.h: 💥 Checking the magic number is up-to-date
Traceback (most recent call last):
File "./run_release.py", line 1283, in <module>
main()
File "./run_release.py", line 1279, in main
automata.run()
File "./run_release.py", line 244, in run
raise e from None
File "./run_release.py", line 241, in run
self.current_task(self.db)
File "release.py", line 126, in __call__
return getattr(self, "function")(db)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "./run_release.py", line 402, in check_magic_number
magic_actual = get_magic(magic_actual_file, magic_actual_re)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "./run_release.py", line 391, in get_magic
if m := regex.search(source.read_text()):
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/pathlib.py", line 1059, in read_text
with self.open(mode='r', encoding=encoding, errors=errors) as f:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/pathlib.py", line 1045, in open
return io.open(self, mode, buffering, encoding, errors, newline)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'cpython/Include/internal/pycore_magic_number.h' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RC/final stage this breaks the build. In previous stages it generates a question whether to continue.
This depends on #152. After that lands, change the base branch here to master. Then you can merge the PR.