Repository navigation
Stop using django.contrib.comments #591
Description
First off, django.contrib.comments is being unbundled from Django and removed in Django 1.8 (and already raises deprecation warnings in Django 1.7). Second, it's overkill for what we're using it for.
Instead, replace it with a simpler model that can live in the jobs app and store the basic information it needs (sender and message, associated with a particular job posting) and use that to handle comments back and forth about job postings.
Activity
ubernostrum commentedon Feb 28, 2015
A quick thought:
The basic idea here is that a comment posted on a job will be sent to the set:
But I don't actually know how we distinguish who will have the ability to see, respond to and post moderator-type comments on job submissions waiting for approval. Is there a
Groupinstance somewhere for that? Should we create one and specify it in settings?frankwiles commentedon Mar 2, 2015
Yes there is a 'Job Board Admin' group, see https://github.com/python/pythondotorg/blob/master/jobs/views.py#L12-L13
Stop using django.contrib.comments and django_comments_xtd
[-]Jobs board: stop using django.contrib.comments[/-][+]Stop using django.contrib.comments[/+]berkerpeksag commentedon Aug 6, 2017
Current status:
django_comments_xtdapp read-only and added a lightweight commenting implementationJobReviewCommentdjango.contrib.commentsanddjango_comments_xtdcompletely:django_comments_xtdfrombase-requirements.txtCOMMENTS_APP = 'django_comments_xtd','django_comments_xtd'and'django.contrib.comments'fromINSTALLED_APPSinpydotorg/settings/base.pytemplates/comments/*Remove django_comments_xtd dependency
Migrate old comments over jobs.JobReviewComment