Repository navigation
Dark theme: "Hide Search Matches" shown on mobile #117
Description
Activity
Okay I found the culprit/fix to restore the previous behaviour (not shown at all). Do we want that or would it actually be desirable to show it?
Given that it is only ever added to either the mobile UI or the desktop UI I feel like it is probably less confusing to suppress it again, aye?
Besides the UI glitch, I was actually glad to discover this "bug" as I'm not fond of matches being highlighted.
I wish it was available on the wide screen UI too.
The problem is that the toggle is only added to the
#searchboxelement of which there can be only one. So either it would not be visible in one of the two layouts or we would have to do some pretty crazy CSS shenanigans to reuse the same search box in the desktop and mobile layout.I wish it was available on the wide screen UI too.
You can press esc to remove the highlights.
Given that it is only ever added to either the mobile UI or the desktop UI I feel like it is probably less confusing to suppress it again, aye?
Yeah, no strong opinion from me, if in doubt let's go for the previous behaviour. Thank you!
Reacted by Anthony Ricaud@septatrix Would you be able to restore the previous behaviour? For me, this is the only one of the reported issues I'd like fixed before deploying this more widely. And I've heard lots of good feedback about the dark theme!
- added a commit that references this issue
on Apr 12, 2023 @septatrix Would you be able to restore the previous behaviour? For me, this is the only one of the reported issues I'd like fixed before deploying this more widely. And I've heard lots of good feedback about the dark theme!
Done, #124 restores the previous behaviour
Reacted by Hugo van Kemenade
Actual result: "Hide Search Matches" is shown subscript to the right of the search box
Expected result: It's either shown more neatly, or, like desktop view, isn't shown at all:
cc @septatrix