Skip to content

Impossible to add a benchmark that exercises newer Python features #281

Description

@AlexWaygood

It appears to be currently impossible to add a benchmark that uses a feature added in Python >3.7. Even if you add the requires-python field in the pyproject.toml file for a specific benchmark, the benchmark is run on all Python versions in CI. This means that the CI will fail if the benchmark includes a feature that is new in 3.8, for example.

This issue currently blocks both of these open PRs:

Activity

  1. brandtbucher commented on Apr 25, 2023

    @brandtbucher
    Member

    Yeah, pyperformance should probably check this somehow and refuse to run certain benchmarks based on the advertised Python version support.

    Another option could be to disable them by default, and enable them when we drop older version support. But that seems less ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions