Skip to content

PEP 780: ABI features as environment markers - #4315

Merged
AA-Turner merged 71 commits into
python:mainfrom
zklaus:new-environment-markers
Mar 25, 2025
Merged

PEP 780: ABI features as environment markers#4315
AA-Turner merged 71 commits into
python:mainfrom
zklaus:new-environment-markers

Conversation

@zklaus

@zklaus zklaus commented Mar 21, 2025 •
edited by AA-Turner
Loading

Copy link
Copy Markdown
Contributor

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4315.org.readthedocs.build/

zklaus added 30 commits March 14, 2025 20:53
@zklaus
Add first pep starting point
b88a226
@zklaus
Add more details to pep
376a535
@zklaus
Flesh out pep
b6a3451
@zklaus
Fix typo
1c201c6
@zklaus
Switch to sysconfig_abi_features syntax
9ebf9b1
@zklaus
Add link to python experimental support for free threading
450f2f2
@zklaus
Add security implications section
d50fe2f
@zklaus
Correct marker syntax
4c9f567
@zklaus
Move abi_features to sys from sysconfig
54f4406
@zklaus
Add debug flag
a0b4af4
@zklaus
Add bitness features
9a04bda
@zklaus
Add more examples
70f433f
@zklaus
Expand Motivation section and adapt examples
55f29cd
@zklaus
Expand Backwards Compatibility section
ca71ebb
@zklaus
Add explanation of sys.abi_features to Abstract
2557a66
@zklaus
Clarify Rejected Ideas section
3eeb70b
@zklaus
Add Open Issues for discussion
a4463e4
@zklaus
Copy editing
8f237e8
@zklaus
Describe ABI features with correct set semantics
86dc717
@zklaus
Add a paragraph about the standard library addition
a95aa70
@zklaus
Add acknowledgments
36ee358
@zklaus
Minor improvements
a4e1664
@zklaus
Make ABI features more prominent
808aa10
@zklaus
Add Ralf to authors and Filipe in acknowledgements
00cc2a5
@zklaus
Improve reference implementation section
4a003fe
@zklaus
Add gil-enabled and clarify mutual exclusion of pairs of features
a035dd9
@zklaus
Add forwards compatibility section
dd0f87c
@zklaus
Make language more authoratitive
2b34025
@zklaus
Clarify debug feature
bb099f2
@zklaus
Include sys.abiflags correspondence in rationale
4636020
@zklaus @AA-Turner
Apply suggestions from code review
f477a5d 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
AA-Turner reviewed Mar 21, 2025
View reviewed changes
Comment thread peps/pep-0780.rst Outdated
AA-Turner
AA-Turner reviewed Mar 21, 2025
View reviewed changes
Comment thread peps/pep-0780.rst Outdated
@zklaus zklaus mentioned this pull request Mar 22, 2025
Closed
zklaus and others added 3 commits March 24, 2025 10:39
@zklaus @AA-Turner
Tighten up Motivation section
067fe46 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@zklaus
Remove Teaser section
b3b40e3
@zklaus
Simplify and shorten abi_features rationale
34c7afe
@zklaus
zklaus requested a review from AA-Turner March 24, 2025 14:32
konstin
konstin reviewed Mar 24, 2025
View reviewed changes
Comment thread peps/pep-0780.rst
@notatallshaw notatallshaw mentioned this pull request Mar 24, 2025
Closed
AA-Turner
AA-Turner approved these changes Mar 24, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final editorial comments (prefixed as such) and two remaining questions -- but these could be taken to the Discourse thread, so don't let it block getting the PR merged.

Thank you!

A

Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst
Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst
Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst Outdated
Comment thread peps/pep-0780.rst
@XuehaiPan XuehaiPan mentioned this pull request Mar 25, 2025
Closed
@AA-Turner

AA-Turner commented Mar 25, 2025

Copy link
Copy Markdown
Member

@zklaus anything outstanding before merging?

XuehaiPan
XuehaiPan reviewed Mar 25, 2025
View reviewed changes
Comment thread peps/pep-0780.rst
@zklaus

zklaus commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

@zklaus anything outstanding before merging?

No. I think this is ready.

Thanks for all the reviews everyone, @pfmoore, and particularly @AA-Turner! I really think it improved the PEP a lot!

@AA-Turner
AA-Turner merged commit 0b971b4 into python:main Mar 25, 2025
@AA-Turner

AA-Turner commented Mar 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@zklaus please now create a discussion thread for the PEP on Discourse, and then open a follow-up PR here to update Post-History and Discussions-To. The PEP has been rendered and is online at https://peps.python.org/pep-0780/.

Thank you!

A

@zklaus
zklaus deleted the new-environment-markers branch March 26, 2025 10:47
@zklaus

zklaus commented Mar 26, 2025

Copy link
Copy Markdown
Contributor Author

@zklaus please now create a discussion thread for the PEP on Discourse, and then open a follow-up PR here to update Post-History and Discussions-To.

Done. The follow-up PR is #4324, the discussion is here.

@zklaus zklaus mentioned this pull request Apr 29, 2025
Closed
ethanfurman pushed a commit to ethanfurman/peps that referenced this pull request Oct 8, 2026
@zklaus @lysnikolaou
@rgommers @AA-Turner @ethanfurman
PEP 780: ABI features as environment markers (python#4315)
7c70827 
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@pfmoore pfmoore pfmoore left review comments
@AA-Turner AA-Turner AA-Turner approved these changes
+2 more reviewers
@konstin konstin konstin left review comments
@XuehaiPan XuehaiPan XuehaiPan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zklaus @lysnikolaou @JelleZijlstra @AA-Turner @rgommers @pfmoore @konstin @XuehaiPan