Repository navigation
PEP 683: Mark Final - #3824
Merged
Merged
PEP 683: Mark Final#3824
Conversation
hugovk
reviewed
Jun 6, 2024
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Member
|
I don't see any issues with the implementation and there we're any major changes after acceptance. |
ericsnowcurrently
marked this pull request as ready for review
June 12, 2024 18:00
|
Three "TODO" notes remain in the document:
Should they be cleaned / completed now that the pep is marked Final? Or is it not worth bothering? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 123: Mark Final)Statuschanged toFinal(andPython-Versionis correct)canonical-docdirective(or
canonical-pypa-specfor packaging PEPs,or
canonical-typing-specfor typing PEPs)Helps #3817
📚 Documentation preview 📚: https://pep-previews--3824.org.readthedocs.build/