Skip to content

PEP 683: Mark Final - #3824

Merged
ericsnowcurrently merged 4 commits into
python:mainfrom
ncoghlan:mark-pep-683-as-final
Jun 12, 2024
Merged

ericsnowcurrently merged 4 commits into
python:mainfrom
ncoghlan:mark-pep-683-as-final

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jun 6, 2024 •

Copy link
Copy Markdown
Contributor
  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3817


📚 Documentation preview 📚: https://pep-previews--3824.org.readthedocs.build/

@ncoghlan
ncoghlan marked this pull request as draft June 6, 2024 07:58
@ncoghlan ncoghlan mentioned this pull request Jun 6, 2024
4 tasks done
Comment thread peps/pep-0683.rst Outdated
ncoghlan and others added 2 commits June 6, 2024 18:40
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@ericsnowcurrently

Copy link
Copy Markdown
Member

I don't see any issues with the implementation and there we're any major changes after acceptance.

@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review June 12, 2024 18:00
@ericsnowcurrently
ericsnowcurrently merged commit 764f563 into python:main Jun 12, 2024
@loic-simon

Copy link
Copy Markdown

Three "TODO" notes remain in the document:

TODO: Update the performance impact for the latest branch (both for GCC and for clang).

TODO: clarify the status of _Py_RefTotal.

TODO: Add a note indicating that the implemented solution does not affect the overall ~performance-neutral~ outcome.

Should they be cleaned / completed now that the pep is marked Final? Or is it not worth bothering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants