Repository navigation
PEP 696: Final round of changes before submitting to SC - #3052
Merged
Merged
Conversation
JelleZijlstra
approved these changes
Mar 12, 2023
CAM-Gerlach
reviewed
Mar 12, 2023
| Created: 14-Jul-2022 | ||
| Python-Version: 3.12 | ||
| Post-History: `22-Mar-2022 <https://mail.python.org/archives/list/typing-sig@python.org/thread/7VWBZWXTCX6RAJO6GG67BAXUPFZ24NTC/>`__, | ||
| `08-Jan-2023 <https://discuss.python.org/t/pep-696-type-defaults-for-typevarlikes/22569/5/>`__, |
Member
There was a problem hiding this comment.
The reason the linter (correctly) flagged this was due to it accidentally being a direct link to an arbitrary post down in the thread, instead of the thread itself. You were able to unintentionally bypass it due to the escape hatch of manually adding a trailing slash (which is not added by Discourse by default, like the post number is) recently implemented in #3005 in response to an author request in #3004 , which allows direct links to specific posts in special cases where the author specifically finds it necessary and intends to do so.
To actually fix this properly, the trailing post number, 5/, should be removed from this URL so it goes to the thread, not an arbitrary post within it.
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pep-previews--3052.org.readthedocs.build/