Skip to content

PEP 565: Fix footnotes - #2741

Merged
hugovk merged 7 commits into
python:mainfrom
hugovk:pep565-fix-footnotes
Aug 4, 2022
Merged

hugovk merged 7 commits into
python:mainfrom
hugovk:pep565-fix-footnotes

Conversation

@hugovk

@hugovk hugovk commented Jul 28, 2022 •

Copy link
Copy Markdown
Member

Fix these warnings:

pep-0565.rst:337: WARNING: Footnote [1] is not referenced.
pep-0565.rst:340: WARNING: Footnote [2] is not referenced.
pep-0565.rst:343: WARNING: Footnote [3] is not referenced.
pep-0565.rst:346: WARNING: Footnote [4] is not referenced.
pep-0565.rst:349: WARNING: Footnote [5] is not referenced.
pep-0565.rst:352: WARNING: Footnote [6] is not referenced.
pep-0565.rst:355: WARNING: Footnote [7] is not referenced.
pep-0565.rst:358: WARNING: Footnote [8] is not referenced.
pep-0565.rst:361: WARNING: Footnote [9] is not referenced.

1-5 and 8-9 were of the format [1_] instead of [1]_.

6-7 are not referred to, so changed those to bullet points.

And then renumbered 8-9 to 6-7.


Also:

  • Consistently format DeprecationWarning as DeprecationWarning to match the majority in this document
  • Replace BPO links with GitHub
  • Remove redundant emacs metadata

Preview

https://pep-previews--2741.org.readthedocs.build/pep-0565/

@hugovk hugovk added the bug label Jul 28, 2022
@hugovk
hugovk requested a review from ncoghlan as a code owner July 28, 2022 10:51

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small related comments, otherwise LGTM

Comment thread pep-0565.rst Outdated
Comment thread pep-0565.rst Outdated
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk !

@hugovk
hugovk merged commit 7f4e764 into python:main Aug 4, 2022
@hugovk
hugovk deleted the pep565-fix-footnotes branch August 4, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants