Skip to content

PEP 642: Fix footnotes - #2718

Merged
brettcannon merged 3 commits into
python:mainfrom
hugovk:pep642-fix-footnotes
Jul 20, 2022
Merged

brettcannon merged 3 commits into
python:mainfrom
hugovk:pep642-fix-footnotes

Conversation

@hugovk

@hugovk hugovk commented Jul 18, 2022 •

Copy link
Copy Markdown
Member

Fix these warnings:

pep-0642.rst:1835: WARNING: Footnote [1] is not referenced.
pep-0642.rst:1838: WARNING: Footnote [2] is not referenced.
pep-0642.rst:1841: WARNING: Footnote [3] is not referenced.
pep-0642.rst:1844: WARNING: Footnote [4] is not referenced.
pep-0642.rst:1847: WARNING: Footnote [5] is not referenced.
pep-0642.rst:1850: WARNING: Footnote [6] is not referenced.
pep-0642.rst:1853: WARNING: Footnote [7] is not referenced.
pep-0642.rst:1856: WARNING: Footnote [8] is not referenced.
pep-0642.rst:1859: WARNING: Footnote [9] is not referenced.

Like #2714, the footnotes in the text should be of the form [1]_ not [1_].


And fix this:

pep-0400.txt:213: WARNING: duplicate label appendix a, other instance in pep-0642.rst

Sphinx treats labels as "global" in the whole docs scope, not at the level of individual documents. So let's use a unambiguous label prefixed with the PEP number, similar to PEP 639 / https://raw.githubusercontent.com/python/peps/main/pep-0639.rst

And there's still an #appendix-a anchor:


Also remove redundant emacs metadata.

Preview

https://pep-previews--2718.org.readthedocs.build/pep-0642/

@hugovk hugovk added the bug label Jul 18, 2022
@hugovk
hugovk requested a review from ncoghlan as a code owner July 18, 2022 13:17
@brettcannon
brettcannon merged commit 3a792e4 into python:main Jul 20, 2022
@hugovk
hugovk deleted the pep642-fix-footnotes branch July 21, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants