Repository navigation
PEP 432: Fix footnotes and syntax highlighting - #2716
Merged
Merged
Conversation
hugovk
requested review from
ericsnowcurrently,
ncoghlan and
vstinner
as code owners
July 15, 2022 18:07
brettcannon
approved these changes
Jul 20, 2022
Member
|
Thanks for the fixes. |
CAM-Gerlach
reviewed
Jul 22, 2022
| Current numbers on my system for Python 3.7 (as built by the Fedora project):: | ||
| Current numbers on my system for Python 3.7 (as built by the Fedora project): | ||
|
|
||
| .. code-block:: shell |
Member
There was a problem hiding this comment.
I think you meant console here (shell is an alias for bash, and this has the $ prompt and output as in console)
Member
Author
There was a problem hiding this comment.
Well spotted, I did!
Please see PR #2729 to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes these warnings:
Similar to #2714: the footnotes in the text should be of the form
[1]_not[1_].Also, as the code blocks are mostly C, set the document default to C (re: PEP 12) instead of Python, with a couple of exceptions for bash/shell:
Preview
https://pep-previews--2716.org.readthedocs.build/pep-0432/