Skip to content

PEP 681: Fix header links - #2507

Merged
CAM-Gerlach merged 2 commits into
mainfrom
JelleZijlstra-patch-1
Apr 16, 2022
Merged

CAM-Gerlach merged 2 commits into
mainfrom
JelleZijlstra-patch-1

Conversation

@JelleZijlstra

Copy link
Copy Markdown
Member

#2481 didn't like the hashes in the URLs

#2481 didn't like the hashes in the URLs
@CAM-Gerlach

CAM-Gerlach commented Apr 16, 2022 •

Copy link
Copy Markdown
Member

Thanks; I've instead updated #2484 to ensure URL fragments are allowed (e.g. skipping to specific posts, as these are); there's no real harm in doing so and it avoids extra work/frustration from authors having to manually trim them. Therefore, this PR isn't really needed any more, unless you/the author don't want to explicitly jump to the specific messages in the thread.

@JelleZijlstra

Copy link
Copy Markdown
Member Author

Since it's the top message in the thread, I feel like it's nicer to link to the whole thread.

@CAM-Gerlach

Copy link
Copy Markdown
Member

Yeah, I agree, and upon closer inspection and visiting the links I see the second one actually appears to link to the wrong message (for me in FF on Windows, my browser doesn't actually jump to it when I first visit the page, only when I press enter again on the link with the page loaded—perhaps Hyperkitty has an issue with its JS triggers.

@CAM-Gerlach CAM-Gerlach added the lint Linter-related work and linting fixes on PEPs label Apr 16, 2022

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JelleZijlstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA signed lint Linter-related work and linting fixes on PEPs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants