Skip to content

PRS: Remove text/plain, upload, and browse logic from pep2html.py - #2376

Closed
AA-Turner wants to merge 1 commit into
python:mainfrom
AA-Turner:cleanup-pep2html
Closed

AA-Turner wants to merge 1 commit into
python:mainfrom
AA-Turner:cleanup-pep2html

Conversation

@AA-Turner

Copy link
Copy Markdown
Member

Whilst we still need to maintain pep2html.py, having a large amount of dead code isn't useful. This is just removing unsed things, without refactoring anything else.

A

@CAM-Gerlach CAM-Gerlach left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -0 on this, since I don't really see the pressing need to strip out content and functionality that has been there nearly untouched for fully 20 years, when the script as a whole (now that PEP 676 should be pronounced on soon) should be retired within a couple months time at most, and to which any non-trivial further changes are effectively frozen anyway. While horribly unmaintainable, it doesn't really need to be maintained anymore, and I find it of historical value as a remarkably well-preserved time capsule into Python's past, so it might be fitting to retain that in the final version at the time it is removed. But perhaps I doth protest too much.

@hugovk

hugovk commented Mar 2, 2022

Copy link
Copy Markdown
Member

Agreed, while image is nice to see, I'd rather wait for the PEP decision and hopefully make it an even bigger minus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants